transformers icon indicating copy to clipboard operation
transformers copied to clipboard
verified publisher icon huggingface

TF Swiftformer

Open amyeroberts opened this issue 2 years ago • 5 comments

Model description

Add the TensorFlow port of the SwiftFormer model. See related issue: #22685

To be done once the SwiftFormer model has been added: #22686

Open source status

  • [X] The model implementation is available
  • [X] The model weights are available

Provide useful links for the implementation

Original repo: https://github.com/amshaker/swiftformer

amyeroberts avatar Apr 14 '23 14:04 amyeroberts

Hi! I would like to take on this as my first issue if possible. Is that okay?

joaocmd avatar Apr 17 '23 23:04 joaocmd

@joaocmd Of course! Cool issue to start on 🤗

If you haven't seen it already, there's a detailed guide in the docs on porting a model to TensorFlow: https://huggingface.co/docs/transformers/add_tensorflow_model

It's best to wait until the PyTorch implementation is merged in, which will be at least a day or two away.

amyeroberts avatar Apr 18 '23 11:04 amyeroberts

Sounds great @amyeroberts, thank you :)

I'll start looking into it once the PyTorch PR is merged.

joaocmd avatar Apr 18 '23 11:04 joaocmd

Any news on this tf model?

D-Roberts avatar Apr 22 '23 14:04 D-Roberts

Hi @D-Roberts, I haven't started looking into it as the pytorch version has not yet been merged.

joaocmd avatar Apr 22 '23 19:04 joaocmd

Hi @joaocmd , the PyTorch version of SwiftFormer is now merged so you can continue working the TensorFlow version of it.

shehanmunasinghe avatar May 13 '23 02:05 shehanmunasinghe

Hi @shehanmunasinghe, I'm on it, thanks!

joaocmd avatar May 13 '23 11:05 joaocmd

Hi @amyeroberts ,

May I proceed to work on this issue if it has not been sorted yet?

sqali avatar Jul 05 '23 12:07 sqali

@sqali There is currently an open PR which is actively being worked on by @joaocmd: #23342

amyeroberts avatar Jul 05 '23 13:07 amyeroberts

Hi @amyeroberts ,

Is there any other issue that you are working on in which I can help you with?

sqali avatar Jul 06 '23 05:07 sqali

@sqali Here's a page in the docs all about different ways to contribute and how to find issues to work on: https://huggingface.co/docs/transformers/main/contributing. I'd suggest looking at issues marked with the 'Good First Issues' tag and finding one which no-one is currently working on: https://github.com/huggingface/transformers/labels/Good%20First%20Issue

amyeroberts avatar Jul 07 '23 13:07 amyeroberts