Improve error message

Open Mahrkeenerh opened this issue 2 years ago • 4 comments

What does this PR do?

Add specific numbers to error message.

@amyeroberts

Mar 24 '23 14:03 Mahrkeenerh

The documentation is not available anymore as the PR was closed or merged.

Mar 24 '23 14:03 HuggingFaceDocBuilderDev

@Mahrkeenerh for the check_repository_consistency tests, running make fix-copies in the top level of the repo should make all the necessary code updates and resolve these. It might be necessary to run make style as well to fix any resulting formatting issues.

Mar 24 '23 14:03 amyeroberts

@amyeroberts ran the commands, and it seems like make style changed 2 unrelated files as well (combined multiline definition into single line), do I add them, or ignore those changes?

Mar 24 '23 17:03 Mahrkeenerh

@Mahrkeenerh OK, thanks for the update. Two things to try:

Rebase from main to include most recent changes
Make sure the most recent style settings and libraries are in the environment pip install -e .[quality]
Run make style again

If they're still being added, push them and I'll re-review to double check the diff's OK.

Mar 24 '23 17:03 amyeroberts

@Mahrkeenerh All looks good to me. Thanks again for this addition!

Mar 24 '23 18:03 amyeroberts

@amyeroberts all green :green_circle:

Mar 24 '23 18:03 Mahrkeenerh