transformers icon indicating copy to clipboard operation
transformers copied to clipboard

Add FAN Model

Open kiansierra opened this issue 3 years ago • 7 comments

What does this PR do?

Fixes #17234

Implements the FAN Models described in this paper and available in the following github repo, Additionally this repo has some of the weights available as described in their README file.

Before submitting

  • [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • [X] Did you read the contributor guideline, Pull Request section?
  • [X] Was this discussed/approved via a Github issue or the forum? Please add a link to it if that's the case.
  • [X] Did you make sure to update the documentation with your changes? Here are the documentation guidelines, and here are tips on formatting docstrings.
  • [X] Did you write any new necessary tests?

This is a cleanup from previous PR #20288 in order to mantain branch integrity, recommendations by @NielsRogge were implemented

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR.

@NielsRogge, @sgugger, @patrickvonplaten

Additional Request

If this PR gets merged, would it be possible to migrate the model files from my HF space to the nvidia space

kiansierra avatar Nov 23 '22 15:11 kiansierra

Hi @sgugger thanks for you're feedback. I'll try to implement the changes soon

kiansierra avatar Dec 03 '22 15:12 kiansierra

Implemented suggestions by @sgugger.

Pending the change on the README.md path, since I'm uncertain if I need to change only the README.md path or the actual doc path.

Also pending rebase

kiansierra avatar Dec 09 '22 12:12 kiansierra

Thanks for working on this! You need to change the link to the doc in the READMEs as suggested, but not the path to the file. You will also need to rebase/resolve the conflicts.

@NielsRogge could you have a review before I do a final pass?

sgugger avatar Dec 09 '22 15:12 sgugger

I've applied the README.md update and rebased the branch.

kiansierra avatar Dec 14 '22 09:12 kiansierra

Hi @NielsRogge, @sgugger.

First of all happy new year, I hope 2023 is greater success than 2022 was for the huggingface team. I've resolved the merge conflicts, and was hoping to know if any additional steps were required for this PR?

kiansierra avatar Jan 03 '23 09:01 kiansierra

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

github-actions[bot] avatar Jan 27 '23 15:01 github-actions[bot]