lighteval icon indicating copy to clipboard operation
lighteval copied to clipboard

Fix a few typos and do a tiny refactor

Open sadra-barikbin opened this issue 1 year ago • 3 comments

Hi there!

To fix a few typos and do a tiny refactor.

sadra-barikbin avatar May 07 '24 19:05 sadra-barikbin

Also there's no argument called model_config defined in both run_evals_accelerate.py and run_evals_nanotron.py. Is this correct?

https://github.com/huggingface/lighteval/blob/51c06d660bb6273947bb9520999263c0666306bc/src/lighteval/models/model_config.py#L274-L275

sadra-barikbin avatar May 07 '24 19:05 sadra-barikbin

hey thanks for the PR ! the model config arg was deprecated in favor of a file. we forgot to remove the in the constructor.

NathanHB avatar May 12 '24 10:05 NathanHB

I'm done @NathanHB

sadra-barikbin avatar May 16 '24 06:05 sadra-barikbin

hey ! thanks for the PR, lgtm, i will test it locally next week and merge asap :)

NathanHB avatar May 31 '24 16:05 NathanHB

Hi @sadra-barikbin , just took a look at your PR! Please revert the import you made and resolve the merge conflicts and we'll be good to merge :)

clefourrier avatar Jul 04 '24 08:07 clefourrier