diffusers icon indicating copy to clipboard operation
diffusers copied to clipboard
Published 3 months ago • verified publisher icon huggingface

[Tests] clean up and refactor gradient checkpointing tests

Open sayakpaul opened this issue 1 year ago • 2 comments

What does this PR do?

Gradient checkpointing is an essential component of model training. We need to ensure it's implemented properly.

If we had them implemented properly we could have avoided the fix from https://github.com/huggingface/diffusers/pull/9489 beforehand. Another related issue: https://github.com/huggingface/diffusers/issues/9496.

Additionally, I took the liberty of properly skipping the related tests with "unittest.skip". This way, we know that tests are being actually skipped.

sayakpaul avatar Sep 23 '24 03:09 sayakpaul

@yiyixuxu WDYT?

sayakpaul avatar Sep 23 '24 06:09 sayakpaul

@DN6 could you give this a look?

sayakpaul avatar Oct 18 '24 05:10 sayakpaul

@DN6 a gentle ping here.

sayakpaul avatar Oct 29 '24 14:10 sayakpaul

Failing test is unrelated.

sayakpaul avatar Oct 31 '24 12:10 sayakpaul