diffusers icon indicating copy to clipboard operation
diffusers copied to clipboard

Add new community pipeline for 'Adaptive Mask Inpainting', introduced in [ECCV2024] ComA

Open jellyheadandrew opened this issue 1 year ago • 8 comments

Add new community pipeline for 'Adaptive Mask Inpainting' introduced in [ECCV2024] Beyond the Contact: Discovering Comprehensive Affordance for 3D Objects from Pre-trained 2D Diffusion Models.

What does this PR do?

This PR implements the 'Adaptive Mask Inpainting' algorithm introduced in [ECCV2024] Beyond the Contact: Discovering Comprehensive Affordance for 3D Objects from Pre-trained 2D Diffusion Models.

The code is borrowed from the author's repository (https://github.com/snuvclab/coma), changed slightly to represent the demo usage.

In a nutshell, this pipeline provides a way to insert human inside the scene image without altering the background, by inpainting with adapting mask.

Fixes # (issue)

Before submitting

  • [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • [x] Did you read the contributor guideline?
  • [ ] Did you read our philosophy doc (important for complex PRs)?
  • [ ] Was this discussed/approved via a GitHub issue or the forum? Please add a link to it if that's the case.
  • [ ] Did you make sure to update the documentation with your changes? Here are the documentation guidelines, and here are tips on formatting docstrings.
  • [ ] Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR.

jellyheadandrew avatar Aug 20 '24 11:08 jellyheadandrew

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

github-actions[bot] avatar Sep 19 '24 15:09 github-actions[bot]

Hi @jellyheadandrew, this seems really interesting, can you please post some example generations of this?

asomoza avatar Sep 19 '24 17:09 asomoza

@asomoza Yeah sure! Completely forgot updating the changes.

https://github.com/user-attachments/assets/7e7d659c-b687-451e-9858-157c1b427edf

image (2)

jellyheadandrew avatar Sep 19 '24 17:09 jellyheadandrew

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Hi @asomoza , I have updated the files based on your feedbacks. Waiting for more feedbacks, or a merge!

jellyheadandrew avatar Oct 11 '24 18:10 jellyheadandrew

Hi @jellyheadandrew sorry it took me so long to get back to you. Let's finish this so we can merge it.

First can you please merge it to the main branch, I can see some couple of outdated imports that will probably fail.

Also can you run make style and make quality.

asomoza avatar Oct 23 '24 04:10 asomoza

@asomoza Hi, I've updated my branch! Could you check

jellyheadandrew avatar Oct 25 '24 15:10 jellyheadandrew

@jellyheadandrew thanks, you merged main but we still need the make style and make quality like it's described in the contributing guide. Without that the tests will fail, also you have some unused imports that will be fixed.

asomoza avatar Oct 25 '24 18:10 asomoza

Thanks @asomoza , I've finished make style and make quality.

jellyheadandrew avatar Nov 03 '24 14:11 jellyheadandrew

@jellyheadandrew merged! thanks for your contribution!

yiyixuxu avatar Nov 06 '24 01:11 yiyixuxu