diffusers icon indicating copy to clipboard operation
diffusers copied to clipboard

refactor SD3, speedup tests

Open a-r-r-o-w opened this issue 1 year ago • 4 comments

What does this PR do?

  • Refactor some of the SD3 modeling implementation. Accessing configuration parameters in __init__ via the config attribute is not necessary or clean. Can use the parameters directly
  • Improve docs
  • Speedup tests

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR.

a-r-r-o-w avatar Aug 13 '24 14:08 a-r-r-o-w

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@DN6 LMK your thoughts here. Will update the expected test slices after approval

a-r-r-o-w avatar Aug 13 '24 22:08 a-r-r-o-w

Will update test slices which are needed due to making models smaller

a-r-r-o-w avatar Sep 03 '24 08:09 a-r-r-o-w

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

github-actions[bot] avatar Sep 27 '24 15:09 github-actions[bot]

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

github-actions[bot] avatar Nov 09 '24 15:11 github-actions[bot]

@a-r-r-o-w is this still relevant?

sayakpaul avatar Nov 09 '24 15:11 sayakpaul

@sayakpaul This is still relevant, yes. We were waiting for SD3.5 to be in when this went stale, so I will revive this soon as it's in now.

a-r-r-o-w avatar Nov 09 '24 16:11 a-r-r-o-w