diffusers icon indicating copy to clipboard operation
diffusers copied to clipboard

[Core] be more specific when doing accelerate imports.

Open sayakpaul opened this issue 1 year ago • 6 comments

What does this PR do?

By being more specific on the imports, we can cut down the overall import time in our library.

Follow this thread: https://huggingface.slack.com/archives/C021H1P1HKR/p1719924173632779.

We should try to identify more such opportunities.

sayakpaul avatar Jul 02 '24 13:07 sayakpaul

@muellerzr just making sure that all of your findings are from accelerate main right?

sayakpaul avatar Jul 02 '24 13:07 sayakpaul

@sayakpaul yep!

muellerzr avatar Jul 02 '24 13:07 muellerzr

So if you want to support older versions/worry about that, definitely feel free to do so. :)

muellerzr avatar Jul 02 '24 13:07 muellerzr

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

IMO it's better to rely on a stable version of accelerate rather than relying on the main branch.

sayakpaul avatar Jul 02 '24 13:07 sayakpaul

Agreed, main won't be main for long (literally this week) so up to you!

muellerzr avatar Jul 02 '24 13:07 muellerzr

@muellerzr so sounds like we won't need this once the new version is released?

yiyixuxu avatar Jul 04 '24 04:07 yiyixuxu

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

github-actions[bot] avatar Sep 14 '24 15:09 github-actions[bot]