diffusers icon indicating copy to clipboard operation
diffusers copied to clipboard

Clarification Needed on Hardcoded Value in Conditional Statement in LeditPP

Open ardofski opened this issue 1 year ago • 0 comments

Hello @manuelbrack,

I was reviewing the source code and came across a line that seems to have a hardcoded value in a conditional statement. The line in question is:

https://github.com/huggingface/diffusers/blob/0bae6e447cba0459456c4f7e7e87d7db141d3235/src/diffusers/pipelines/ledits_pp/pipeline_leditspp_stable_diffusion.py#L1053

I understand that this condition decides whether cross_attention_mask, intersect_mask, or noise_mask is going to be used in the diffusion step, but any clarification on this this condition about the following questions will be appreciated:

  • What is the significance of the value 800?
  • Is this value based on empirical data, theoretical calculations, or an arbitrary choice?
  • Are there specific scenarios or conditions under which this threshold was determined?
  • Would it be possible to include a comment or documentation explaining this choice for future reference?

Thank you for your help!

ardofski avatar Jul 01 '24 20:07 ardofski