diffusers icon indicating copy to clipboard operation
diffusers copied to clipboard

fix min-snr implementation

Open ethansmith2000 opened this issue 1 year ago • 2 comments

What does this PR do?

Fixes the implementation of min-snr training for v-prediction models

Based on implementation seen here. https://github.com/kohya-ss/sd-scripts/blob/main/library/custom_train_functions.py#L66

These two graphs show the weight scheme based on timestep from the kohya implementation. epssnr v-predsnr

the current implementation in diffusers takes the eps weight and increases everything by + 1, it appears that the +1 should be relocated to the denominator

  • Schedulers: @yiyixuxu
  • Training examples: @sayakpaul

ethansmith2000 avatar Jun 11 '24 00:06 ethansmith2000

@ethansmith2000 a gentle ping :)

sayakpaul avatar Jun 24 '24 08:06 sayakpaul

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

github-actions[bot] avatar Sep 14 '24 15:09 github-actions[bot]

@ethansmith2000 would you be able to make style? will merge once CI is green and we will ask the community to apply the same change

yiyixuxu avatar Nov 17 '24 01:11 yiyixuxu

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

github-actions[bot] avatar Dec 11 '24 15:12 github-actions[bot]

Will merge after the CI is green.

sayakpaul avatar Dec 12 '24 04:12 sayakpaul