diffusers icon indicating copy to clipboard operation
diffusers copied to clipboard

add dockerfile for Ascend NPU

Open MengqingCao opened this issue 1 year ago • 6 comments

What does this PR do?

Add dockerfile for Ascend NPU, based on PyTorch.

Before submitting

  • [N/A] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • [X] Did you read the contributor guideline?
  • [X] Did you read our philosophy doc (important for complex PRs)?
  • [ ] Was this discussed/approved via a GitHub issue or the forum? Please add a link to it if that's the case.
  • [ ] Did you make sure to update the documentation with your changes? Here are the documentation guidelines, and here are tips on formatting docstrings.
  • [N/A] Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR.

cc @sayakpaul @yiyixuxu @DN6

MengqingCao avatar May 16 '24 08:05 MengqingCao

I am not opposed to having this Dockerfile but I don't think we have test cases in the library yet that would benefit from the corresponding Docker image. We only have limited support for NPUs which was introduced in https://github.com/huggingface/diffusers/pull/7916.

So, I am going to defer to @yiyixuxu to make a call here.

sayakpaul avatar May 16 '24 08:05 sayakpaul

I am not opposed to having this Dockerfile but I don't think we have test cases in the library yet that would benefit from the corresponding Docker image. We only have limited support for NPUs which was introduced in #7916.

I got what you mean. A small question, are all the Dockerfiles in this repo work for UT test or CI? I thought this was for users to quickly set up their own development environment.

MengqingCao avatar May 16 '24 09:05 MengqingCao

A small question, are all the Dockerfiles in this repo work for UT test or CI? I thought this was for users to quickly set up their own development environment.

Both.

sayakpaul avatar May 16 '24 09:05 sayakpaul

I think we don't need this just yet? cc @DN6

yiyixuxu avatar May 20 '24 17:05 yiyixuxu

We don't have access to NPUs in our CI, so I don't think we can add it here.

DN6 avatar May 21 '24 10:05 DN6

@sayakpaul @yiyixuxu @DN6 thanks for your suggestion! I think it's better to reopen this pr after the access to NPU and related UTs are ready.

MengqingCao avatar May 25 '24 03:05 MengqingCao

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

github-actions[bot] avatar Sep 14 '24 15:09 github-actions[bot]