diffusers icon indicating copy to clipboard operation
diffusers copied to clipboard

[Single file] fix single file config loading when passing dicts.

Open sayakpaul opened this issue 1 year ago • 3 comments

What does this PR do?

Fixes https://github.com/huggingface/diffusers/actions/runs/9055285304/job/24876182073#step:7:3821

sayakpaul avatar May 13 '24 13:05 sayakpaul

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

also I thought we are moving all the single-file tests to the same place? are these tests intended to be kept there?

yiyixuxu avatar May 13 '24 17:05 yiyixuxu

Yeah, I think so too.

https://github.com/huggingface/diffusers/tree/main/tests/single_file has all the tests but I think we need to remove them from tests/models/unets/ and elsewhere.

sayakpaul avatar May 14 '24 02:05 sayakpaul

Actually this test and functionality should be removed. We don't support configuring models via dict in from_pretrained so from_single_file shouldn't support it either. config should be a model repo id or a path to a local model repo. I'll update the test.

DN6 avatar May 21 '24 11:05 DN6

Closing the PR then :)

sayakpaul avatar May 21 '24 11:05 sayakpaul