diffusers icon indicating copy to clipboard operation
diffusers copied to clipboard

[Core] introduce videoprocessor.

Open sayakpaul opened this issue 1 year ago • 5 comments

What does this PR do?

Introduces a VideoProcessor akin to VaeImageProcessor to encapsulate the logic of dealing with videos.

TODOs

  • [x] Add tests
  • [x] Docs

sayakpaul avatar Apr 25 '24 08:04 sayakpaul

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@DN6 please review https://github.com/huggingface/diffusers/pull/7861 first.

sayakpaul avatar May 06 '24 05:05 sayakpaul

@yiyixuxu @DN6 now that https://github.com/huggingface/diffusers/pull/7861 is in, WDYT about merging this? I have also added documentation.

sayakpaul avatar May 07 '24 04:05 sayakpaul

The failing test is completely unexpected. Need to look deeper. @yiyixuxu WDYT about the preprocess_video refactor btw?

sayakpaul avatar May 07 '24 06:05 sayakpaul

@yiyixuxu could you look into the failing test? It's likely coming from image processor. But if not, let me know.

sayakpaul avatar May 08 '24 21:05 sayakpaul

could you look into the failing test? It's likely coming from image processor. But if not, let me know.

@sayakpaul can confirm that test failure is due to image processor, I will fix it!

yiyixuxu avatar May 10 '24 04:05 yiyixuxu

@yiyixuxu I think I have addressed your comments. LMK if this is good to merge.

sayakpaul avatar May 10 '24 09:05 sayakpaul

i left one comment https://github.com/huggingface/diffusers/pull/7776/files#r1597075529 we should accept same video input format across all our pipelines, I don't think that animatediff need to be different other than that it looks good to me!

yiyixuxu avatar May 10 '24 18:05 yiyixuxu

we should accept same video input format across all our pipelines, I don't think that animatediff need to be different

Okay. I will delete the block that listifies a single image.

sayakpaul avatar May 10 '24 18:05 sayakpaul

feel free to merge once the tests pass :)

yiyixuxu avatar May 10 '24 18:05 yiyixuxu