diffusers icon indicating copy to clipboard operation
diffusers copied to clipboard

[`Tests`] Update deprecated `output_type="numpy"` in test files and fix several typos

Open tolgacangoz opened this issue 1 year ago • 1 comments

This pull request updates the deprecated output_type="numpy" to output_type="np" in the test files, and fixes several typos. @stevhliu

tolgacangoz avatar Mar 11 '24 10:03 tolgacangoz

Sorry for the unrelated commit history. I reversed them.

tolgacangoz avatar Mar 12 '24 10:03 tolgacangoz

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Yeah, that is not necessarily about timesteps. I am updating the docstring then?

tolgacangoz avatar Mar 12 '24 18:03 tolgacangoz

Yeah, let's just keep the changes that are related to numpy --> np

stevhliu avatar Mar 12 '24 18:03 stevhliu

I couldn't understand. Should I change timesteps to w in the get_guidance_scale_embedding()'s docstring? Plus, in the code, of course.

tolgacangoz avatar Mar 12 '24 18:03 tolgacangoz

Sorry I wasn't clear before! Let's keep w in the code and change the docstring from timesteps to w.

  1. Keep w in the code and change the docstring from timesteps to w.
  2. Update the parameter description for it. Currently, it says "generate embedding vectors at these timesteps" but that's not the clearest or most accurate. Instead, let's say something like: "Generate embedding vectors with a specified guidance scale to subsequently enrich timestep embeddings."

stevhliu avatar Mar 13 '24 17:03 stevhliu

There are lots of other deprecation warnings in tests. Can/Should I open another PR(s) to update them?

tolgacangoz avatar Mar 13 '24 18:03 tolgacangoz

Yeah you can open a separate PR for the deprecation warnings. It'd be better to keep the focus of this PR on just numpy to np and updating the docstring from timestep to w with a clearer parameter description.

stevhliu avatar Mar 13 '24 22:03 stevhliu

Thanks for reviewing and merging!

tolgacangoz avatar Mar 14 '24 19:03 tolgacangoz