diffusers icon indicating copy to clipboard operation
diffusers copied to clipboard

[`IP-Adapter`] Fix IP-Adapter Support and Refactor Callback for Panorama Pipeline

Open tolgacangoz opened this issue 1 year ago • 3 comments

Fixes #7064 for StableDiffusionPanoramaPipeline. It looks like most of the work has already been done. StableDiffusionPanoramaPipeline class seems to pass the tests of IPAdapterTesterMixin in my local setup.

Thanks for this opportunity! @yiyixuxu

tolgacangoz avatar Mar 09 '24 16:03 tolgacangoz

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

StableDiffusionPanoramaPipeline class passes the tests of IPAdapterTesterMixin when I set ..., device="cuda").to(torch_device) here. But when device="cpu" as expected for fast CPU tests, it cannot pass. I am currently working on this.

tolgacangoz avatar Mar 11 '24 13:03 tolgacangoz

The last commit seems to resolve the issue. Now, I am working on adding callback_on_step_end.

tolgacangoz avatar Mar 11 '24 16:03 tolgacangoz

@yiyixuxu Here is ready for a review.

tolgacangoz avatar Mar 19 '24 20:03 tolgacangoz

can you make sure the quality tests pass?

yiyixuxu avatar Mar 19 '24 22:03 yiyixuxu

Done!

tolgacangoz avatar Mar 21 '24 06:03 tolgacangoz

There were 2 errors. One went away when I merged with the main branch and the other seems irrelevant to me in terms of this PR.

FAILED tests/pipelines/test_pipelines.py::CustomPipelineTests::test_remote_components
- ImportError: cannot import name 'PositionNet' from 'diffusers.models.embeddings'
(/__w/diffusers/diffusers/src/diffusers/models/embeddings.py)

tolgacangoz avatar Mar 22 '24 07:03 tolgacangoz

Thanks for merging!

tolgacangoz avatar Mar 25 '24 06:03 tolgacangoz