diffusers icon indicating copy to clipboard operation
diffusers copied to clipboard

fixed deprecation error for euler_discrete scheduler steps offset

Open mariopenglee opened this issue 1 year ago • 1 comments

What does this PR do?

In accordance to the deprecation message: deprecate("steps_offset!=1", "1.0.0", deprecation_message, standard_warn=False) is outdated. "steps_offset should be set to 1 instead of 0. Please make sure to update the config accordingly as leaving steps_offset might led to incorrect results in future versions. If you have downloaded this checkpoint from the Hugging Face Hub, it would be very nice if you could open a Pull request for the scheduler/scheduler_config.json file"

I changed the default value to 1 and edited the documentation to reflect the changes.

Before submitting

  • [X] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • [X] Did you read the contributor guideline?
  • [X] Did you read our philosophy doc (important for complex PRs)?
  • [ ] Was this discussed/approved via a GitHub issue or the forum? Please add a link to it if that's the case.
  • [X] Did you make sure to update the documentation with your changes? Here are the documentation guidelines, and here are tips on formatting docstrings.
  • [X] Did you write any new necessary tests?

Who can review?

@yiyixuxu

mariopenglee avatar Mar 07 '24 19:03 mariopenglee

hey! thanks for the PR but we cannot accept it that deprecation message is sent only from SD pipelines - changing the default will break some other pipelines when using this scheduler

this is somewhat related https://github.com/huggingface/diffusers/pull/7128

yiyixuxu avatar Mar 09 '24 01:03 yiyixuxu

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

github-actions[bot] avatar Apr 07 '24 15:04 github-actions[bot]