diffusers icon indicating copy to clipboard operation
diffusers copied to clipboard

Dreambooth SDXL LoRA - Update PEFT for DoRA

Open shawnrushefsky opened this issue 1 year ago • 4 comments

The sdxl script assumes the presence of a dora related property that does not exist until peft 0.9.0

What does this PR do?

Recent updates to the sdxl dreambooth lora training script require a newer version of peft to be installed.

Before submitting

  • [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • [x] Did you read the contributor guideline?
  • [x] Did you read our philosophy doc (important for complex PRs)?
  • [ ] Was this discussed/approved via a GitHub issue or the forum? Please add a link to it if that's the case.
  • [ ] Did you make sure to update the documentation with your changes? Here are the documentation guidelines, and here are tips on formatting docstrings.
  • [ ] Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR.

@sayakpaul

shawnrushefsky avatar Mar 07 '24 17:03 shawnrushefsky

DoRA can be only used with peft installed from source and we make it clear from the readme. I don’t think this PR is relevant in that case.

sayakpaul avatar Mar 07 '24 19:03 sayakpaul

It breaks for non-DoRA training as well, though.

shawnrushefsky avatar Mar 07 '24 20:03 shawnrushefsky

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

github-actions[bot] avatar Apr 07 '24 15:04 github-actions[bot]

Let's just pin the version of PEFT to be at least 0.9.0.

sayakpaul avatar Jun 30 '24 05:06 sayakpaul