diffusers icon indicating copy to clipboard operation
diffusers copied to clipboard

Wrong scale of dynamic thresholding in Jax implementation

Open alex8937 opened this issue 2 years ago • 3 comments

https://github.com/huggingface/diffusers/blob/f4fc75035f2d567dfe00fc6b8671ecd38dd144b2/src/diffusers/schedulers/scheduling_dpmsolver_multistep_flax.py#L164

Apparently, q in jnp.percentile should between [0, 100] instead of [0, 1] as in torch.

alex8937 avatar Mar 01 '24 08:03 alex8937

Cc: @patil-suraj @pcuenca ^.

sayakpaul avatar Mar 03 '24 06:03 sayakpaul

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

github-actions[bot] avatar Mar 31 '24 15:03 github-actions[bot]

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

github-actions[bot] avatar Apr 25 '24 15:04 github-actions[bot]