diffusers icon indicating copy to clipboard operation
diffusers copied to clipboard

Bug fix for controlnetpipeline check_image

Open Fantast616 opened this issue 2 years ago • 7 comments

Bug fix for controlnetpipeline check_image when using multicontrolnet and prompt list

Fixes # (issue) https://github.com/huggingface/diffusers/issues/7102

@sayakpaul

Fantast616 avatar Feb 26 '24 14:02 Fantast616

can we add a test here? for multi-controlnet and prompt list ? https://github.com/huggingface/diffusers/blob/ad310af0d65d5a008401ebde806bed413156cf82/tests/pipelines/controlnet/test_controlnet.py#L280

yiyixuxu avatar Feb 26 '24 22:02 yiyixuxu

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

can we add a test here? for multi-controlnet and prompt list ?

https://github.com/huggingface/diffusers/blob/ad310af0d65d5a008401ebde806bed413156cf82/tests/pipelines/controlnet/test_controlnet.py#L280

OK Done, It already had an multiple prompt test before: 469 def test_inference_multiple_prompt_input(self): but its' prompt size is equals to controlnet number, so it didn't find the problem. I modify the input prompt size to 4 now.

Fantast616 avatar Feb 28 '24 06:02 Fantast616

@yiyixuxu could you give this a look again?

sayakpaul avatar Mar 01 '24 06:03 sayakpaul

@Fantast616 test still fails - can you look into that?

yiyixuxu avatar Mar 04 '24 01:03 yiyixuxu

can you fix the quality test?

yiyixuxu avatar Mar 09 '24 04:03 yiyixuxu

can you fix the quality test?

Sorry for having other things recently, which may not be modified in time

Fantast616 avatar Mar 09 '24 04:03 Fantast616

gentle pin @Fantast616

yiyixuxu avatar Mar 27 '24 23:03 yiyixuxu

thank you ver much :)

yiyixuxu avatar Mar 28 '24 18:03 yiyixuxu