diffusers icon indicating copy to clipboard operation
diffusers copied to clipboard

Controlnet weight decay

Open seokjin1013 opened this issue 1 year ago • 6 comments

I am working on creating a pipeline using a1111 or comfyui and implementing it with diffusers. In the controlnet mode of a1111, there is an option called 'my prompt is more important.' According to the internal implementation, this feature slowly decays from 1 by 0.85 at each denoising step. This greatly affects the quality of the output. (The weight decay feature is also supported in comfyui.) I have successfully implemented this feature indirectly through the call_back_on_step_end callback function. However, I face the inconvenience of having to manually reset the variable used for decay after each inference. Please officially support weight decay. Thank you.

seokjin1013 avatar Jan 25 '24 14:01 seokjin1013

hi: I would like to understand more about this

I face the inconvenience of having to manually reset the variable used for decay after each inference.

we added call_back_on_step_end for user cases exactly like this one! so I want to know why it is inconvenient and how can we improve it:)

YiYi

yiyixuxu avatar Feb 08 '24 21:02 yiyixuxu

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

github-actions[bot] avatar Mar 04 '24 15:03 github-actions[bot]

gentle pin here @seokjin1013 if you can share your implementation for weight decay vis callbacks on our forums here, it will be great! https://github.com/huggingface/diffusers/discussions/categories/ideas

It can also help us to understand how we can make it more convenient for people to use this feature

yiyixuxu avatar Mar 04 '24 23:03 yiyixuxu

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

github-actions[bot] avatar Mar 29 '24 15:03 github-actions[bot]

not stale?

Scorpinaus avatar Mar 29 '24 21:03 Scorpinaus

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

github-actions[bot] avatar Apr 23 '24 15:04 github-actions[bot]

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

github-actions[bot] avatar Sep 14 '24 15:09 github-actions[bot]