diffusers icon indicating copy to clipboard operation
diffusers copied to clipboard

expose ff_multiplier argument of Transformer

Open kashif opened this issue 3 years ago • 2 comments

This PR exposes the ff_multiplier option of the Attention so that the UNet is able to set it.

cc @sayakpaul

kashif avatar Feb 21 '23 11:02 kashif

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

I believe the wrapper function will register all the arguments to the config and since now ff_multiplier is there it should also register it.

kashif avatar Feb 21 '23 12:02 kashif

@patrickvonplaten no this was to make smaller student unets for the distillation experiments

kashif avatar Mar 03 '23 18:03 kashif

@kashif is the intention to only add the config to the feedforward of the middle block of the unet or to all down and up blocks that use a transformer for their cross attention mechanism?

As is, I see we also add the config to a few other block in the unetblocks2d but because the ff_multiplier isn't passed through get_{down,up}_block, they won't receive the config.

williamberman avatar Mar 05 '23 17:03 williamberman

for now, we wanted it for all attention feedforward blocks... but yes middle ones would also work i suppose. let me fix the get_ helpers...

kashif avatar Mar 05 '23 18:03 kashif

I'd say we only merge this PR if we have a powerful distilled SD model - otherwise no need yet to expose more parameters IMO

patrickvonplaten avatar Mar 07 '23 11:03 patrickvonplaten

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

github-actions[bot] avatar Mar 31 '23 15:03 github-actions[bot]

@kashif should we close this for now? I'm ok with revisiting in the future

williamberman avatar Apr 04 '23 18:04 williamberman

yes please! i only needed it for my experiments. closing!

kashif avatar Apr 04 '23 18:04 kashif