diffusers icon indicating copy to clipboard operation
diffusers copied to clipboard

Forward pass of ScoreSdeVeScheduler scheduler is missing

Open cameronalonso2 opened this issue 3 years ago • 3 comments

Describe the bug

Hi, Forward pass is missing for this scheduler https://github.com/huggingface/diffusers/blob/v0.10.2/src/diffusers/schedulers/scheduling_sde_ve.py#L45 It would be great if this could be added. Could you give me some pointers how I can implement the forward pass?

thanks

Reproduction

Logs

-

System Info

cameronalonso2 avatar Dec 10 '22 06:12 cameronalonso2

Hey @cameronalonso2,

Indeed the step() function is missing there. The SDE VE scheduler is not really used at the moment, so this is not super urgent. But feel free to implement a step() method yourself that uses both step_pred and step_correct

patrickvonplaten avatar Dec 11 '22 16:12 patrickvonplaten

Hi @patrickvonplaten thanks for the reply, sorry I meant forward pass i.e., add_noise function is missing. Is there a reference how to implement this part? Also, similarly in the VP method https://github.com/huggingface/diffusers/blob/main/src/diffusers/schedulers/scheduling_sde_vp.py this is missing the add_noise function, I very much appreciate any hint on how to implement it.

thank you.

cameronalonso2 avatar Dec 11 '22 19:12 cameronalonso2

Ah I see, that's a good question! I think you should be able to find it in this codebase: https://github.com/yang-song/score_sde :-)

patrickvonplaten avatar Dec 13 '22 17:12 patrickvonplaten

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

github-actions[bot] avatar Jan 09 '23 15:01 github-actions[bot]