Is this correct ?

Open taki0112 opened this issue 3 years ago • 1 comments

Hello

L312 in use_conv=False is it correct ?

if correct, then this line is same to fir=='sde_vp'.

I think use_conv=True is correct.. Also, L320 in use_conv=True is correct.

Aug 01 '22 07:08 taki0112

Hi @taki0112! Pinging @patil-suraj to check, but it's probably a bit of logic that was left for compatibility with future models :)

Aug 03 '22 13:08 anton-l

Hey @taki0112,

I think use_conv=False is correct here since the integration tests for those models all pass: https://huggingface.co/models?arxiv=arxiv:2011.13456

Closing this for now. Please ping me or re-open if you find a bug due to use_conv

Sep 13 '22 15:09 patrickvonplaten