diffusers icon indicating copy to clipboard operation
diffusers copied to clipboard

Possible Bug in DDIMScheduler when prediction_type = 'sample'

Open JianxinMa opened this issue 3 years ago • 0 comments

Describe the bug

https://github.com/huggingface/diffusers/blob/v0.9.0/src/diffusers/schedulers/scheduling_ddim.py#L303 https://github.com/huggingface/diffusers/blob/v0.9.0/src/diffusers/schedulers/scheduling_ddim.py#L278

It seems that the ``model_output'' at L303 should be the predicted epsilon. However, it is actually the predicted original sample when prediction_type == "sample".

A workaround is to use ``use_clipped_model_output=True''. And the results are much worse if use_clipped_model_output=False, even when clip_sample=False.

Reproduction

No response

Logs

No response

System Info

  • diffusers version: 0.9.0
  • Platform: macOS-12.6-x86_64-i386-64bit
  • Python version: 3.9.7
  • PyTorch version (GPU?): 1.10.0 (False)
  • Huggingface_hub version: 0.10.1
  • Transformers version: 4.23.1
  • Using GPU in script?:
  • Using distributed or parallel set-up in script?:

JianxinMa avatar Nov 30 '22 12:11 JianxinMa