diffusers icon indicating copy to clipboard operation
diffusers copied to clipboard

`deprecate` should point to the usage of the deprecated thing

Open keturn opened this issue 3 years ago • 1 comments

This warning message:

/opt/hostedtoolcache/Python/3.10.8/x64/lib/python3.10/site-packages/diffusers/utils/deprecation_utils.py:35: FutureWarning: It is deprecated to pass a pretrained model name or path to from_config.If you were trying to load a scheduler, please use <class 'diffusers.schedulers.scheduling_lms_discrete.LMSDiscreteScheduler'>.from_pretrained(...) instead. Otherwise, please make sure to pass a configuration dictionary instead. This functionality will be removed in v1.0.0. warnings.warn(warning + message, FutureWarning)

does not tell me anything about where the offending usage of from_config is taking place.

It should probably be using the stacklevel argument to warn so it doesn't just point to a line in your deprecate function all the time.

keturn avatar Nov 30 '22 03:11 keturn

Yes, 100% agree. Thanks for the issue. Opening a PR

patrickvonplaten avatar Nov 30 '22 10:11 patrickvonplaten