controlnet_aux icon indicating copy to clipboard operation
controlnet_aux copied to clipboard

The annotator of controlnet has updated

Open ZihaoW123 opened this issue 2 years ago • 3 comments

Will this repo be updated according to https://github.com/Mikubill/sd-webui-controlnet/tree/main/annotator?

ZihaoW123 avatar May 23 '23 03:05 ZihaoW123

Sorry, I don't fully understand the question here - could you clarify?

patrickvonplaten avatar May 23 '23 12:05 patrickvonplaten

I assume the concern (which I also have) is implementation divergence but also new features. E.g. the HED implementation changed here:

https://github.com/Mikubill/sd-webui-controlnet/commit/f4cd2d51f6c09a1dac3bfb85d6d0aa8de7f738d2

With a similar commit made in ControlNet-v1-1-nightly. Between those two repos I am not sure if one is more authoritative, but I expect the A1111 extension gets more attention to potential edge cases.

I did a comparison of the LineartDetector in controlnet_aux and A1111:

  • controlnet_aux loads both the regular and coarse models into memory instead of having two instances
  • controlnet_aux uses hf_hub_download for model management
  • controlnet_aux supports PIL images in addition to numpy
  • controlnet_aux performs resizing and inversion

Using hf_hub_download is preferred for me and the rest are issues I could handle application side.

@patrickvonplaten - are there other design differences that should be maintained? I could help with updating implementations but it would be useful to know how you want the library to evolve.

pdoane avatar May 26 '23 15:05 pdoane

I just put up #48 that gets the implementation consistent with work done in sd-webui-controlnet. I'll look into porting over the other annotators soon.

pdoane avatar May 27 '23 15:05 pdoane