compression-test icon indicating copy to clipboard operation
compression-test copied to clipboard

*** COMPRESSION ERROR in simple.

Open frkay opened this issue 13 years ago • 5 comments

When compressing spiegel.de.har, other compressions work fine.

frkay avatar Jan 18 '13 01:01 frkay

yea, I'm sure there are some bugs in there. I"d ignore it for now unless it is pervasive. -=R

On Thu, Jan 17, 2013 at 5:16 PM, frkay [email protected] wrote:

When compressing spiegel.de.har, other compressions work fine.

— Reply to this email directly or view it on GitHubhttps://github.com/http2/compression-test/issues/8.

grmocg avatar Jan 18 '13 01:01 grmocg

This is caused by either:

  • dates not being reconstituted as the exact same string
  • the scheme not coming back (because it isn't preserved, much as in HTTP/1)

I'm going to adjust the comparison function to account for at least the date (as it'll be common in other compressors too, and we don't need that level of information to be preserved).

mnot avatar Jan 18 '13 04:01 mnot

Oh, and you can find out why by passing a higher verbosity (e.g., -v 2, IIRC).

mnot avatar Jan 18 '13 04:01 mnot

yea, I'm sure there are some bugs in there. I"d ignore it for now unless it is pervasive, my guess is that there are two exact copies of something in a request or response. -=R

On Thu, Jan 17, 2013 at 5:16 PM, frkay [email protected] wrote:

When compressing spiegel.de.har, other compressions work fine.

— Reply to this email directly or view it on GitHubhttps://github.com/http2/compression-test/issues/8.

grmocg avatar Jan 18 '13 05:01 grmocg

It's my simple compressor. E.g.,

- mismatch in simple: expires has mismatched values
  a -> Mon, 26 Jul 1997 05:00:00 GMT
  b -> Sat, 26 Jul 1997 05:00:00 GMT

I don't think any candidate compressor needs to preserve this much information :)

mnot avatar Jan 18 '13 06:01 mnot