desktop icon indicating copy to clipboard operation
desktop copied to clipboard

Close all tabs button has no conformation dialog

Open farhaduneci opened this issue 3 years ago • 2 comments

Checklist

  • [X] I've searched for similar issues.
  • [X] I'm using the latest version of HTTPie.

Minimal reproduction code and steps

  1. Open a bunch of Tabs and work on a project
  2. Do not save them
  3. Press Close all tabs button and lose everything :boom:.

Current result

If you open multiple tabs and close them individually, there will be a pop-up dialog wanting you to confirm the action, as being said in How we lost 54k GitHub stars article this is a perfect choice! But unfortunately, this is not implemented for more-important task of group deleting tabs in the application! If you press Close all tabs button, everything gets deleted right away.

This also aplies to all other group-deleting features of the application like Close all other tabs and others.

Expected result

A confirmation dialog must be shown like other destructive actions.


Additional information, screenshots, or code examples

image

farhaduneci avatar Jul 15 '22 19:07 farhaduneci

Hi @Farhaduneci, thanks for the feedback!

When you close a tab, we don’t delete anything. All your work is continuously auto-saved.

Requests that don’t belong to any collection are stored in the Drafts list:

Screenshot 2022-07-15 at 22 40 56

Maybe you missed the Drafts feature?

jkbrzt avatar Jul 15 '22 20:07 jkbrzt

Thank you for your response, Yes, I missed that one (such a cool feature :star_struck:), but I still believe a pop-up will make everything more clear here.

farhaduneci avatar Jul 16 '22 05:07 farhaduneci