tide icon indicating copy to clipboard operation
tide copied to clipboard
verified publisher icon http-rs

Add websockets

Open Yarn opened this issue 5 years ago • 2 comments

Adds websocket support.

Description

See ticket for now.

Motivation and Context

Some people need websockets.

https://github.com/http-rs/tide/issues/67

How Has This Been Tested?

tbd (existing cargo tests pass) https://github.com/Yarn/tide_ws_test

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [x] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [ ] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [ ] All new and existing tests passed.

Yarn avatar Aug 21 '20 19:08 Yarn

What's the plan forward for these PRs? Do you want to hand them off?

jbr avatar Sep 03 '20 05:09 jbr

I'd like a close code review, especially for the async-h1 changes. Probably benchmarking too, I have a new computer that will probably have less sporadic performance issues so I can probably do that now if there are benchmarks written.

If people want to contribute docs/tests/examples I definitely wouldn't mind but I am planning to work on it more.

Yarn avatar Sep 03 '20 07:09 Yarn