http-client icon indicating copy to clipboard operation
http-client copied to clipboard

(feat) update hyper to 0.14

Open sunng87 opened this issue 4 years ago • 10 comments

Fixes #73

sunng87 avatar Mar 02 '21 15:03 sunng87

This doesn't compile. Can you make sure you run check and tests locally via:

cargo check --no-default-features --features=hyper_client

cargo test --no-default-features --features=hyper_client

Fishrock123 avatar Mar 02 '21 18:03 Fishrock123

Sorry, let me check later today

sunng87 avatar Mar 03 '21 02:03 sunng87

It seems the main branch doesn't compile on wasm either, due to error from getrandom.

sunng87 avatar Mar 03 '21 14:03 sunng87

@Fishrock123 it compiles on all targets. However, because the getrandom dependency was introduced in http-types, I'm not sure if it's good to add target check here

sunng87 avatar Mar 04 '21 14:03 sunng87

@sunng87 Could you add a separate feature flag for this? That we we can land it sooner.

Fishrock123 avatar Apr 22 '21 15:04 Fishrock123

@Fishrock123 I'm not quite sure if a feature flag could fix this. Could you please show me some detail about that?

sunng87 avatar Apr 23 '21 15:04 sunng87

I've just run into this via https://github.com/http-rs/surf/issues/295, is there any action to follow this up?

Firstyear avatar Sep 14 '21 05:09 Firstyear

this could work but needs to be under a versioned flag, e.g. hyper-014

Fishrock123 avatar Sep 14 '21 17:09 Fishrock123

@Fishrock123

Do you mean that you prefer a feature flag such as:

[features]
wasm_getrandom = ["getrandom/js"]
wasm_client = ["other features",  "wasm_getrandom"]

Instead of:

[target.'cfg(target_arch = "wasm32")'.dependencies.getrandom]
version = "0.2.2"
features = ["js"]

Otherwise, can you elaborate so we can get this merged soon? :)

niklasad1 avatar Dec 07 '21 18:12 niklasad1

Please review this PR, it would be great to be able to use surf with Tokio 1.0 :-)

19h avatar May 01 '22 00:05 19h