node-dash-button icon indicating copy to clipboard operation
node-dash-button copied to clipboard

Adding tool to rebuild CSV and updating Mac Addresses.

Open grmartin opened this issue 8 years ago • 8 comments

grmartin avatar Aug 15 '17 12:08 grmartin

Coverage Status

Coverage remained the same at 98.413% when pulling d7eefdd0eafdc1608d250451f9a004b677714885 on grmartin:master into f15ce0fcd9c3006a45d59cc6f83b2a57ae321ae4 on hortinstein:master.

coveralls avatar Aug 15 '17 12:08 coveralls

can you remove the .idea metadata and resubmit?

hortinstein avatar Aug 15 '17 14:08 hortinstein

@hortinstein are you referring to the .gitignore addition? There is no actual .idea file content.

grmartin avatar Aug 15 '17 14:08 grmartin

?

grmartin avatar Aug 20 '17 02:08 grmartin

@hortinstein ... due to your lack of response... i removed the only reference (in the .gitignore) from the patch, if only in the hope you will main-line this.

grmartin avatar Aug 24 '17 19:08 grmartin

Coverage Status

Coverage remained the same at 98.413% when pulling 45e2d71aeb9e0352c613a668cb707a67abcb3aed on grmartin:master into f15ce0fcd9c3006a45d59cc6f83b2a57ae321ae4 on hortinstein:master.

coveralls avatar Aug 24 '17 19:08 coveralls

hey sorry been busy and neglecting this.

I misread the idea references, my bad.

While stor.js contains mac addresses, I don't see it referenced in the source anywhere. I see a reference to use it with the tool with a CSV file...is that stor.js? Also are you planning on updating the readme to show how this can be used.

Thanks

hortinstein avatar Aug 30 '17 01:08 hortinstein

No worries.

stor.js was the list your findbutton bin uses.

I can add instructions to the readme on how to update the CSV tomorrow... though I did leave a quick set in the header of the tool JS file.

Sent using the mail.com mail app

On 8/29/17 at 21:21, Alex Hortin wrote:

hey sorry been busy and neglecting this.

I misread the idea references, my bad.

While stor.js contains mac addresses, I don't see it referenced in the source anywhere. I see a reference to use it with the tool with a CSV file...is that stor.js? Also are you planning on updating the readme to show how this can be used.

Thanks

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/hortinstein/node-dash-button/pull/58#issuecomment-325850101

grmartin avatar Aug 30 '17 02:08 grmartin