website icon indicating copy to clipboard operation
website copied to clipboard

docs[snippets]: add stripe webhook integration

Open hideokamoto-stripe opened this issue 1 year ago • 2 comments

I added a page introducing how to create an API using Hono to handle Stripe Webhook events.

Context

https://github.com/orgs/honojs/discussions/2518#discussioncomment-9170675

To add protection processing for the API endpoint, Stripe Webhooks require the raw request body. I created an article with sample code explaining how to obtain this for both Node.js and Cloudflare.

By adding this article, users using Stripe with Hono will find it easier to understand the integration method, and it will be easier to provide support in case of issues or discussions.

hideokamoto-stripe avatar May 09 '24 02:05 hideokamoto-stripe

Hey @hideokamoto-stripe

Awesome! I've left one comment. Please check it.

yusukebe avatar May 09 '24 07:05 yusukebe

Thank you @yusukebe -san! I updated the file to add the section.

hideokamoto-stripe avatar May 09 '24 08:05 hideokamoto-stripe

Hello @yusukebe -san, I updated the code snippet according to your feedback. As a result, we can make it simpler than before. I also gained a deeper understanding of Hono through this process.

Please feel free to provide your comments about this update. Thank you.

hideokamoto-stripe avatar May 16 '24 05:05 hideokamoto-stripe

Hi @hideokamoto-stripe

Then, are both codes necessary? Perhaps it can be one code example?

https://github.com/honojs/website/pull/347/files#diff-910a6082d7a38d32704ca78b93bf4923af1096c6861f072daab4f5e51753e8fcR30-R52

https://github.com/honojs/website/pull/347/files#diff-910a6082d7a38d32704ca78b93bf4923af1096c6861f072daab4f5e51753e8fcR65-R104

yusukebe avatar May 17 '24 08:05 yusukebe

@yusukebe I've removed unnecessary code snippets 👍

hideokamoto-stripe avatar May 18 '24 12:05 hideokamoto-stripe

@hideokamoto-stripe

Thanks! I've left one more comment. Check it.

yusukebe avatar May 18 '24 13:05 yusukebe

@yusukebe Oh, I forgot to remove it. I've removed it!

hideokamoto-stripe avatar May 18 '24 14:05 hideokamoto-stripe

@hideokamoto-stripe

Thanks! Let's ship it.

yusukebe avatar May 18 '24 15:05 yusukebe