vite-plugins icon indicating copy to clipboard operation
vite-plugins copied to clipboard
verified publisher icon honojs

Does not work on deno

Open mcandeia opened this issue 1 year ago • 5 comments

  1. Checkout the repo: https://github.com/mcandeia/hono-vite-dev-server-deno-repro-issue.git (started from https://remix.run/docs/en/main/guides/vite#getting-started)
  2. run deno install
  3. run deno run dev
  4. make a request and check that the headers are always empty

e.g:

curl "http://localhost:5173" -H 'X-Custom-Header: value'

mcandeia avatar Oct 23 '24 00:10 mcandeia

Hi @mcandeia

I think this is not a @hono/vite-dev-server matter. This may be a Remix or hono-remix-adapter issue, but I'm not sure Remix fully supports Deno.

yusukebe avatar Oct 25 '24 07:10 yusukebe

It does support @yusukebe I've been running remix + Deno2.0 succesfully in production since deno2 release. But you might be right, it could be somehow related to hono/node-server. instead

mcandeia avatar Nov 06 '24 11:11 mcandeia

Seeing something similar as well. No Remix, just Deno + Hono. Repro: https://github.com/callmephilip/hono-vite-dev-server-deno-missing-headers

callmephilip avatar May 14 '25 09:05 callmephilip

Correction: works fine on deno 2.3

callmephilip avatar May 14 '25 14:05 callmephilip

Correction: works fine on deno 2.3

This is good news! So this issue can be closed?

yusukebe avatar May 16 '25 19:05 yusukebe