Issue with RequestError having static name property

[GavinMeierSonos]

Hard to say if this is a rollup issue or if this is a valid concern but the fix would be easy to implement.

When transpiling into esm. There is an issue with name being defined as a static value on the RequestError instead of just having it defined in the in the constructor. It throws an error saying that read only property name cannot be reassigned.

Happy to open a PR if this would be approved since it wouldn't impact any existing functionality and it does seem odd to define a static field on a class that is defined on the prototype. The fix would be to move the name assignment to the constructor after the super is called.

[yusukebe]

Hi @GavinMeierSonos

Can you share the details to understand more easily or share the project to reproduce it?

[HelloWorld017]

When this module is transpiled using swc, the output contain things like this:

let _getResponseCache;
var _class, _body, _init;
var RequestError = (_class = class extends Error {
    constructor(message, options){
        super(message, options);
    }
}, _class.name = "RequestError", _class);

And when it is evaluated in strict mode, following error occurs.

TypeError: Cannot assign to read only property 'name' of function 'class extends Error {
     constructor(message, options){
         super(message, options);
     }
}

[himself65]

I have the same error when use swc

[himself65]

change target to "target": "esnext" in tsconfig will workaround this

[yusukebe]

Hi @himself65

I'm not so faminiro to swc. I've tried but it does not throw an error. Can you share the instructions to reproduce it?

[himself65]

https://play.swc.rs/?version=1.11.29&code=H4sIAAAAAAAAA02MQQqDQAxF954iOxU8gVC66gV6g2EaZGhNpkmGCsW7N44WzCLwfl4%2BLpnFIL6CKtzxXVDtJsICuBjSQ2GnbwOgFixFoDAjXKA9262fI5OalGgsnSPAjKphwtEfJdE01JCzJRevY63cJoai6FzoSfyhmq6%2B%2B8PQklG6o2z4F%2FTNZq0%2FGIkI7sAAAAA%3D&config=H4sIAAAAAAAAA1WPSw7DIAxE9zkF8rqLikUXvUMPgagTUfETdqSiKHcvJEDbHZ5h%2FMbbJAS8SMNdbOVZhqgSYRpzUSh7Vu%2BiAOeIpJOJDJfuMlVrVpbwkPbTAVZpQa4pJHmVsiXAhkBYZE4rNskZb%2Bb8i9TBxYREffOgOeUXi%2F%2FAqUHBhed6mO2UWvcscIPvpw4bi8HQoydrq2n%2FALtj80kWAQAA

[yusukebe]

@himself65 Thanks!