middleware icon indicating copy to clipboard operation
middleware copied to clipboard
verified publisher icon honojs

[oauth-providers] Problem with GitHub provider from version 0.5.0

Open geommr opened this issue 1 year ago • 3 comments

starting from version 0.5.0 the redirect to callback no longer works on OAuth apps (returns HTTP 400 with body "Not found"). the getEmail refactor removes the this.oauthApp check, which is where I suspect the problem is -- v0.4.0 was working as expected.

Tested both on Hono v4.5.11.

I can open a PR if someone confirms this, repo can be found here for testing.

geommr avatar Sep 06 '24 14:09 geommr

Hi @geommr !

@monoald Can you handle this?

yusukebe avatar Sep 10 '24 05:09 yusukebe

This just hit me. Wasted quite a bit of time. Reverting to 0.4.0 worked.

John-Colvin avatar Jan 22 '25 11:01 John-Colvin

Can confirm this is a problem, and patching it with the suggested solution worked.

Gerbuuun avatar Mar 06 '25 16:03 Gerbuuun

fixed in this PR: #1372

mrdear avatar Aug 12 '25 03:08 mrdear

fixed in this PR: #1372

you can close this issue @yusukebe

mrdear avatar Aug 12 '25 07:08 mrdear

@mrdear Thanks

yusukebe avatar Aug 12 '25 11:08 yusukebe