hono icon indicating copy to clipboard operation
hono copied to clipboard

ci: Display performance measurement results as custom metrics

Open k2tzumi opened this issue 1 year ago • 2 comments

The author should do the following, if applicable

  • [ ] Add tests
  • [ ] Run tests
  • [ ] bun run format:fix && bun run lint:fix to format the code
  • [ ] Add TSDoc/JSDoc to document the code

What's this all about?

This will be an improvement in type checking performance monitoring added by the following Pull Request. https://github.com/honojs/hono/pull/3406

In conjunction with octocov, type checking performance will be displayed as Pull Request comments and CI summary as follows

k2tzumi avatar Oct 05 '24 09:10 k2tzumi

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.70%. Comparing base (f5bad77) to head (8ba2da0). Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3491   +/-   ##
=======================================
  Coverage   91.70%   91.70%           
=======================================
  Files         159      159           
  Lines       10145    10145           
  Branches     2863     2896   +33     
=======================================
  Hits         9303     9303           
  Misses        840      840           
  Partials        2        2           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

codecov[bot] avatar Oct 05 '24 09:10 codecov[bot]

Hi @k2tzumi

Sorry for the late reply. This is great! But please wait a bit for the discussion in PR https://github.com/honojs/hono/pull/3443 to be finished.

yusukebe avatar Oct 10 '24 20:10 yusukebe

@yusukebe

There is a discussion going on for #3443, is there anything we should address in our PR here?

k2tzumi avatar Nov 02 '24 15:11 k2tzumi

If this PR is taken in, additional action may be needed.

k2tzumi avatar Nov 13 '24 04:11 k2tzumi

Hi @k2tzumi Thanks for nice work. As you said, if https://github.com/honojs/hono/pull/3661 is merged, I think we should add custom metrics. (or before it's merged)

EdamAme-x avatar Nov 13 '24 05:11 EdamAme-x

@EdamAme-x Thanks for the comment! Once #3661 is merged, I’d like to add the bundle size to the custom metrics!

k2tzumi avatar Nov 13 '24 09:11 k2tzumi

Thank you all, these are nice improvements! Type performance is the only thing I mildly warn about when recommending hono to everyone! I love seeing how hono and its ecosystem is improving every week and hoping to contribute back with our own OS projects. Keep up the great work.

flipvh avatar Nov 13 '24 12:11 flipvh

@k2tzumi

I merged #3661!

yusukebe avatar Nov 15 '24 08:11 yusukebe

I'm starting to have the desire to clean up the commit log.

k2tzumi avatar Nov 16 '24 01:11 k2tzumi

Hi @k2tzumi

I realized that the codes in perf-measures are not formatted. I've created the PR and merged it into the main: https://github.com/honojs/hono/pull/3683

Can you apply this change (merge main into this PR)?

yusukebe avatar Nov 18 '24 06:11 yusukebe

@k2tzumi

Sorry! I forgot to add a linter for the perf-measures directory. I've added it to this PR: https://github.com/honojs/hono/pull/3686

Could you update this PR?

yusukebe avatar Nov 18 '24 23:11 yusukebe

Hi @EdamAme-x

Also, can you review this?

yusukebe avatar Nov 18 '24 23:11 yusukebe

I was not able to verify the execution of jobs in perf-measures-type-and-bundle-check-on-main, so I tried it and found several problems, so I fixed them. I've reflected the results in the Issue comment, so please check it out.

k2tzumi avatar Nov 18 '24 23:11 k2tzumi

@k2tzumi @EdamAme-x

Thank you! Let's land it!

yusukebe avatar Nov 19 '24 04:11 yusukebe

Wooow, super cool! https://github.com/honojs/hono/pull/3666#issuecomment-2484697912

yusukebe avatar Nov 19 '24 04:11 yusukebe