iOSPlot icon indicating copy to clipboard operation
iOSPlot copied to clipboard
verified publisher icon honcheng

Major issue with Graphing

Open nielswh opened this issue 13 years ago • 3 comments

Hi There,

I ran into an issue with the line plot and brought my app to its knees performance wise. I finally determined where the issue was. Its on line 73 of LineGraphView.m You make a call to UIGraphicsPushContext(ctx); but then never call UIGraphicsPopContext(); I'm not 100% sure if you need either though.

Thanks, Niels

nielswh avatar Jan 10 '13 17:01 nielswh

So it works fine when u take it out?

Sent from my iPad

On 11 Jan, 2013, at 1:50 AM, Niels Hansen [email protected] wrote:

Hi There,

I ran into an issue with the line plot and brought my app to its knees performance wise. I finally determined where the issue was. Its on line 73 of LineGraphView.m You make a call to UIGraphicsPushContext(ctx); but then never call UIGraphicsPopContext(); I'm not 100% sure if you need either though.

Thanks, Niels

— Reply to this email directly or view it on GitHub.

honcheng avatar Jan 10 '13 23:01 honcheng

I just added UIGraphicsPopContext(); at the end and then it worked great. Need the pop after the push :)

Sent from my iPhone

On Jan 10, 2013, at 4:47 PM, honcheng [email protected] wrote:

So it works fine when u take it out?

Sent from my iPad

On 11 Jan, 2013, at 1:50 AM, Niels Hansen [email protected] wrote:

Hi There,

I ran into an issue with the line plot and brought my app to its knees performance wise. I finally determined where the issue was. Its on line 73 of LineGraphView.m You make a call to UIGraphicsPushContext(ctx); but then never call UIGraphicsPopContext(); I'm not 100% sure if you need either though.

Thanks, Niels

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub.

nielswh avatar Jan 11 '13 00:01 nielswh

Thanks. Can you send me a pull request, just so I can credit you for the fix?

Sent from my iPad

On 11 Jan, 2013, at 8:03 AM, Niels Hansen [email protected] wrote:

I just added UIGraphicsPopContext(); at the end and then it worked great. Need the pop after the push :)

Sent from my iPhone

On Jan 10, 2013, at 4:47 PM, honcheng [email protected] wrote:

So it works fine when u take it out?

Sent from my iPad

On 11 Jan, 2013, at 1:50 AM, Niels Hansen [email protected] wrote:

Hi There,

I ran into an issue with the line plot and brought my app to its knees performance wise. I finally determined where the issue was. Its on line 73 of LineGraphView.m You make a call to UIGraphicsPushContext(ctx); but then never call UIGraphicsPopContext(); I'm not 100% sure if you need either though.

Thanks, Niels

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub.

honcheng avatar Jan 11 '13 00:01 honcheng