node-pty-prebuilt-multiarch icon indicating copy to clipboard operation
node-pty-prebuilt-multiarch copied to clipboard
verified publisher icon homebridge

Support for NodeJS 23

Open NorthernMan54 opened this issue 1 year ago • 8 comments

Breaking Change

  • Support for NodeJS 16 and older has been removed
  • Support for the original RPI, and PI Zero (armv6) has been removed

Significant Changes

  • Added Support for NodeJS 23
  • Refresh of Docker images to bookwork and NodeJS 22 runtime
  • Remove seperate abi_registry.json, and use node-api version
  • Refreshed node-pty code from https://github.com/microsoft/node-pty ( Used squash and merge into Current Branch )

Other Changes

This pull request includes several updates to configuration files, build scripts, and documentation to support newer versions of Node.js and Electron, as well as improvements to the build environment. The most important changes are summarized below:

Configuration Updates:

  • Added a new configuration file .config/tsaoptions.json to define TSA options for the project.
  • Updated .eslintrc.js to include additional ignore patterns for the scripts directory.

Build Environment Enhancements:

  • Updated the Node.js and Electron build targets in .github/workflows/Prepare prebuild environment.yml to include newer versions and removed older versions. [1] [2] [3] [4] [5]
  • Changed the base images in .github/workflows/Prepare prebuild environment.yml and .prebuild/Dockerfile.debian to use Debian Bookworm instead of Buster. [1] [2] [3] [4] [5]

Documentation Updates:

  • Updated README.md to reflect the new minimum supported versions of Node.js and Electron. [1] [2]

Removal of Deprecated Files:

  • Removed the deprecated .prebuild/abi_registry.json file and associated references in build scripts. [1] [2] [3] [4]

Pipeline Configuration:

  • Updated azure-pipelines.yml to use 1ES pipeline templates and improved the build job configurations for Linux, macOS, and Windows. [1] [2] [3]

NorthernMan54 avatar Nov 13 '24 14:11 NorthernMan54

The change in build nodejs version breaks bullseye

From discord - https://discord.com/channels/432663330281226270/687483994048167970/1310621193161674782

Bullseye 11 running on Pi 3 B+ Node version 20.18.0 HB version 1.8.5

image

NorthernMan54 avatar Nov 25 '24 15:11 NorthernMan54

For tracking purposes

njuart avatar Nov 25 '24 15:11 njuart

@njuart I think this now fixes your issue - https://github.com/homebridge/node-pty-prebuilt-multiarch/actions/runs/12061552022

Tomorrow, I'm going to add this to the UI beta, and publish

NorthernMan54 avatar Nov 28 '24 03:11 NorthernMan54

When will support for Node 23 be live? Thank you for maintaining this library!

jahooma avatar Jan 08 '25 23:01 jahooma

@jahooma If your using this with Homebridge, the UI beta 5 branch leverages this PR?

https://github.com/homebridge/homebridge-config-ui-x/blob/7d33872090508ebc9ed20f2f846d4d0dadc5d2df/package.json#L86

NorthernMan54 avatar Jan 09 '25 00:01 NorthernMan54

Thank you for your efforts in supporting node-pty prebuilt packages across platforms and different versions. Looking forward to the NodeJS v23 support to land. Thank you! 🎉

exsilium avatar Jan 29 '25 08:01 exsilium

How complete is this Pull Request now? When will it be ready for use?

bietiaop avatar Feb 02 '25 04:02 bietiaop

The PR has been tested for a few months with Homebridge so it should be fine to use. If you need it in your project, just use the beta version tag in your config.JSON

NorthernMan54 avatar Feb 02 '25 08:02 NorthernMan54