Do not mount systemd-journal-gatewayd.sock in Supervisor container

Open sairon opened this issue 1 year ago • 1 comments

Devcontainer doesn't have systemd running, so there is no journal gateway daemon. Bind-mounting the path only creates an empty directory.

This reverts commit ce761c00a2a70100c465b052ae7ef1eaa54b2579 (PR #6)

Apr 22 '24 08:04 sairon

Thanks for catching this.

I probably used a custom devcontainer.json which bind mounts the socket into the dev container (and from there into the Supervisor container). But this is not the default in current devcontainer.json, so this "dangling" mount is really a bit weird.

Now thinking a bit more, maybe we could consider making it conditional? As in check if it is present, and bind mount if it is? It could be helpful for testing... :thinking:

Apr 22 '24 08:04 agners