core icon indicating copy to clipboard operation
core copied to clipboard

Add airtouch5

Open danzel opened this issue 2 years ago • 12 comments

Proposed change

Add integration for the Airtouch 5 AC/Zone controller. This has been used/tested by multiple people in the forum The airtouch5py library is over here

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [x] New integration (thank you!)
  • [ ] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request: https://github.com/home-assistant/home-assistant.io/pull/28523
  • Link to brands pull request: https://github.com/home-assistant/brands/pull/4594

Checklist

  • [x] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [x] There is no commented out code in this PR.
  • [x] I have followed the development checklist
  • [x] I have followed the perfect PR recommendations
  • [x] The code has been formatted using Black (black --fast homeassistant tests)
  • [x] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [x] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [x] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [x] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

danzel avatar Aug 09 '23 22:08 danzel

Hi @danzel

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

home-assistant[bot] avatar Aug 09 '23 22:08 home-assistant[bot]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] avatar Aug 09 '23 22:08 home-assistant[bot]

How essential is "When adding new integrations, limit included platforms to a single platform. Please reduce this PR to a single platform"?

I can remove them if needed, and then submit them after this is merged. Would rather just do 1 PR though. (I'd keep the climate entity, that is the most important one)

danzel avatar Aug 09 '23 22:08 danzel

@edenhaus Removed all except climate, linked to the library in the initial post. Thanks

danzel avatar Aug 19 '23 01:08 danzel

Have fixed what I can from the comments and rebased to fix build issues.

danzel avatar Aug 21 '23 22:08 danzel

Hi folks, can we please bump this one up in the queue please, it's been dragging on for a long time. I know we're only Australia and a tiny portion of the market, yada yada, but it has been a while.

Kaldek avatar Oct 05 '23 09:10 Kaldek

A PR in draft will be considered still in progress and not ready for another review. Therefore, we give less attention to drafted PRs. @danzel Please mark the PR ready for review by clicking "Ready for review" after implementing the requested changes.

Sorry but I have to ask you again to fix the merge conflicts first

edenhaus avatar Oct 11 '23 10:10 edenhaus

Would it possible to extend the airtouch4 integration to support also the version 5?

The airtouch4 library integration with airtouch 5 devices is not good. It was easier to write a new library than fix its airtouch5 compatibility

danzel avatar Nov 01 '23 20:11 danzel

Some small cleanups, and then we are ready to merge :)

Done, thanks for all the reviews

danzel avatar Nov 20 '23 06:11 danzel

@danzel are you please able to complete the final checks on this one?

bolistik avatar Dec 05 '23 00:12 bolistik

Eventually. Feel free to fix it yourself if you have the time


From: bolistik @.> Sent: Tuesday, December 5, 2023 1:10:28 PM To: home-assistant/core @.> Cc: David Leaver @.>; Mention @.> Subject: Re: [home-assistant/core] Add airtouch5 (PR #98136)

@danzelhttps://github.com/danzel are you please able to complete the final checks on this one?

— Reply to this email directly, view it on GitHubhttps://github.com/home-assistant/core/pull/98136#issuecomment-1839778120, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAC767W2V626MDCCSUD37HLYHZQ7JAVCNFSM6AAAAAA3KU2GS6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZZG43TQMJSGA. You are receiving this because you were mentioned.Message ID: @.***>

danzel avatar Dec 05 '23 00:12 danzel

Changes applied, I needed to disable a warning to allow except Exception:, not sure why it wasn't required before.

danzel avatar Jan 14 '24 23:01 danzel

@danzel Can you please implement the suggested changes in the docs PR?

edenhaus avatar Jan 16 '24 09:01 edenhaus

(Close + reopen to re-run CI)

emontnemery avatar Jan 23 '24 07:01 emontnemery

@danzel Can you please implement the suggested changes in the docs PR?

Sorry, I missed those, looks like you've applied them, thanks.

danzel avatar Jan 23 '24 20:01 danzel