core icon indicating copy to clipboard operation
core copied to clipboard
Published 4 months ago • verified publisher icon home-assistant

Fix QNAP fail to load

Open disforw opened this issue 11 months ago • 1 comments

Breaking change

Proposed change

Fixing bug after release 2025.05. This fixes the following opened issues: #144536 #144023

Type of change

  • [ ] Dependency upgrade
  • [x] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [ ] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • [ ] The code change is tested and works locally.
  • [ ] Local tests pass. Your PR cannot be merged unless tests pass
  • [ ] There is no commented out code in this PR.
  • [ ] I have followed the development checklist
  • [ ] I have followed the perfect PR recommendations
  • [ ] The code has been formatted using Ruff (ruff format homeassistant tests)
  • [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

disforw avatar May 11 '25 12:05 disforw

So how does this fix it? We now swallow the exception, why is the exception caused? If i remember the issues it was about not able to support the async context manager

joostlek avatar May 11 '25 13:05 joostlek

This looks better @peternash

disforw avatar May 13 '25 11:05 disforw

If im supost to understand any of this i dont!!

garrathbond avatar May 19 '25 20:05 garrathbond