Palazzetti integration
Breaking change
No breaking changes
Proposed change
New integration for Palazzetti stoves
Type of change
- [ ] Dependency upgrade
- [ ] Bugfix (non-breaking change which fixes an issue)
- [x] New integration (thank you!)
- [ ] New feature (which adds functionality to an existing integration)
- [ ] Deprecation (breaking change to happen in the future)
- [ ] Breaking change (fix/feature causing existing functionality to break)
- [ ] Code quality improvements to existing code or addition of tests
Additional information
- This PR fixes or closes issue: fixes #
- This PR is related to issue:
- Link to documentation pull request: https://github.com/home-assistant/home-assistant.io/pull/35195
Checklist
- [x] The code change is tested and works locally.
- [x] Local tests pass. Your PR cannot be merged unless tests pass
- [x] There is no commented out code in this PR.
- [x] I have followed the development checklist
- [x] I have followed the perfect PR recommendations
- [x] The code has been formatted using Ruff (
ruff format homeassistant tests) - [x] Tests have been added to verify that the new code works.
If user exposed functionality or configuration variables are added/changed:
- [x] Documentation added/updated for www.home-assistant.io
If the code communicates with devices, web services, or third-party tools:
- [x] The manifest file has all fields filled out correctly.
Updated and included derived files by running:python3 -m script.hassfest. - [x] New or updated dependencies have been added to
requirements_all.txt.
Updated by runningpython3 -m script.gen_requirements_all. - [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
To help with the load of incoming pull requests:
- [ ] I have reviewed two other open pull requests in this repository.
Not sure about the 2 failed checks:
- The license audit is failing for palazzetti-sdk-local-api, its github page mentions the MIT license
- The tests that fail don't seem to be related to my changes
It looks like it's failing because the MIT license isn't present in setup.py.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:
@zweckj @joostlek I think I have addressed all your comments.
Aight, I pulled the code and I fixed the last things. You now will have translated fan modes, better tests (I removed the other example, I think airgradient isn't the best example anymore, but in that case I have 2 different devices and then we have something different to test, which is different from the same but different data) and a test for the device