android icon indicating copy to clipboard operation
android copied to clipboard

Disable TileService elements in Manifest until the user enables them for use

Open fabikw opened this issue 1 year ago • 4 comments

Home Assistant Android app version(s): 2024.4.1-full Android version(s): 14 (AP1A.240405.002.B1) Device model(s): Google Pixel 7 Pro Home Assistant version: N/A Last working Home Assistant release (if known): N/A Description of problem, include YAML if issue is related to notifications: The first 12 TileServices declared in the manifest in https://github.com/home-assistant/android/blob/master/app/src/main/AndroidManifest.xml#L437 are enabled. This causes them to be visible in the tiles that can be added in Edit Mode for Quick Settings (and it takes a lot of space). Could the components instead be enabled programatically as they are needed (when the user sets them up)? Looking at https://github.com/home-assistant/android/blob/d640b9d9748a88c533afe61721e2af0915659081/app/src/main/java/io/homeassistant/companion/android/settings/qs/TileSlot.kt#L29 it seems that this is the goal, but instead of only 4 more enabled, there are 12 enabled by default.

Companion App Logs:


Screenshot or video of problem:

Additional information:

fabikw avatar May 13 '24 22:05 fabikw

this was by design, so this is a enhancement and not a bug. We started out with 12 tiles originally and they were always enabled.

dshokouhi avatar May 13 '24 22:05 dshokouhi

it seems that this is the goal, but instead of only 4 more enabled, there are 12 enabled by default.

To add to what @dshokouhi said as the person who implemented this: the goal is highest number used + 4 more with a minimum of 12 :) Because it was the default but also to prevent breaking changes / make it obvious that there are more than a few tiles.

jpelgrom avatar May 14 '24 04:05 jpelgrom

Could we have a way of disabling the components for tiles that are not set up? Having 12 extra tiles there is a lot.

fabikw avatar May 16 '24 00:05 fabikw

the tasker app AutoNotifications has 40 actually, every app is going to be different. This is not a screen that is always visible to the user either. You go in there add your tile and move on.

dshokouhi avatar May 16 '24 00:05 dshokouhi