Johannes Holke comments

Results 97 comments of


                                            Johannes Holke

Improvement: indent ignore list and unification of indent scripts [1/2]

I just noticed that t8indent.sh and check_if_file_indented.sh are nearly identical and i either have to replicate code and put it into check_if_file_indented.sh or unify those files. Will do the later...

Improvement: indent ignore list and unification of indent scripts [1/2]

Unified both scripts. However, there is still a bug since now all files are reported as indented by our pre-commit hook.

Improvement: indent ignore list and unification of indent scripts [1/2]

I commented to indent script. I remove the "-o" option since it did not work and we never used it either. Back to you @lenaploetzke

Maximum level and linear index

Thanks, Carsten. Does the solution from #499 also cover the original PR? Sorry, that we did not integrate it, i think it got lost in the duplicate repository confusion. Having...

Feature: extend leaf face neighbor to non-balanced forests and ghosts [N/N]

I am taking this out of draft and into review now :) I split this up in multiple PRs that should be merged before this one. See the list in...

Feature: extend leaf face neighbor to non-balanced forests and ghosts [N/N]

It is now possible to compute the face neighbor if the forest has no ghost (then no neighbor are found for process boundary elements). Extended the function and added a...

Test the new vtk reader

Related to #140

Run valgrind check in ci in parallel

> Depending on #1922 #1922 is now resolved :)

Tests fail on more than 2 procs

#1100 may fix test/t8_forest_incomplete/t8_gtest_iterate_replace, please check

Tests fail on more than 2 procs

#1142 should resolve the test/t8_forest_incomplete/t8_gtest_iterate_replace