feat(json): introduce MarshalJSONHex
A bit of an edge case, but cannot seem to get payload unmarshalling to be happy.
Codecov Report
Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
Project coverage is 99.88%. Comparing base (
ce90883) to head (8e56e89). Report is 5 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #182 +/- ##
===========================================
- Coverage 100.00% 99.88% -0.12%
===========================================
Files 5 5
Lines 1666 1668 +2
===========================================
Hits 1666 1666
- Misses 0 2 +2
I don't quite see the point of this. The MarshalJSONHex is not part of any interface that I know of, so it cannot be auto-detected and used by encoders. And if you need to explicitly use it, you might aswell just use Hex() directly.
I was torn about this PR as well. The reason here was to provide api surface to allow uint256's to be used in an ExecutionPayload more naturally.
In geth right now you have to write a custom marshal function if the consensus side type of your ExecutionPayload uses a uint256, else geth will freak out.
This is the broader issue i'm trying to tackle, open to other suggestions
In geth right now you have to write a custom marshal function if the consensus side type of your ExecutionPayload uses a uint256, else geth will freak out.
How does this PR make any difference, though?
Seems abandoned. Please reopen if that was not the case