Transport extension

Open Britaliope opened this issue 9 months ago • 1 comments

closes #66

@nsowen @hoijui new MR because i can't modify the source branch of the existing one

Apr 17 '25 23:04 Britaliope

Notes for review:

I haven't been able to run the tests on my machine (some weird issues about Assert not being recognized, i'm not really used to the java ecosystem and haven't been able to fix it). I tested on my very simple app that use this and it works, but if someone else can run the tests to see if everything is fine it would be great.
I changed the setter style to this.<varname> = <varname> instead of arbitrary different name into the whole OSCPort{In,Out}Builder classes for consistency. This cascaded into a rename of some private variables (see the full explaination above) which makes the full diff a bit messy to read. It is in a separate commit so you can review things separately.
I rebased (not merged, that's the workflow i'm used to) the branch on hoijui/master and fixed the conflicts. I can re-do this with a merge if you prefer.

Apr 17 '25 23:04 Britaliope