hoaproject
`compiler:pp -s` and `compiler:pp -v dump` should have colors
@jubianchi did a good POC with it. It is a great idea. We should do that. Maybe @jubianchi could explain more.
Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
let me show an example :
This is a custom colorization I made manually in one of my slides.
What should be done:
- [ ] Choose a color for namespace names
- [ ] Choose a color for token names
- [ ] Choose a color for token values
- [ ] Choose a color for rules
- [ ] Use those color in the token sequence (
-s) output - [ ] Use those color in the dump visitor (
-v dump) output - [ ] Use those color in the trace (
-t) output
@jubianchi Automatic color selection, in a palette. Each token or namespace without a color has a color attached automatically, and it remains attached. This way, this is easy to track the token by its color instead of its name.
@jubianchi For instance, regarding your example, T_NUMBER will be blue, T_OP_PLUS will be orange, T_VAR will be red, but T_OP_EQUAL will not be orange but pink instead. All token value will have the color associated to its token name. Same for namespace.
Moreover, I would like something like highlight_code for a beautiful display ;)
I experimented with some algorithms to colorize the output and it seems hard to do it automatically:
- we have to generate random color with reasonable distance, or
- we have to hardcode a color palette which is large enough to deal with with huge grammars, but
- we would have to take care of user's terminal background (color cannot be the same on light and dark backgrounds)
If we choose to generate random color on-the-fly, we will have to add too much code (IMHO) to compute random colors, deal with distances between them, etc.
If we choose to hardcode a palette, we would have to hardcode two palettes: one for light backgrounds and one for dark ones. Or we have to find a palette working with both backgrounds.
Can we specify in an other file, which color to join for each token. Perhaps a %filename%.pp-lut relative to %filename%.pp
Or shall we think about a "check style" tool? An extra file setup the coding style and the token style (text color, line break, spacing, etc) Perhaps there is the same thought.
@1e1 I don't understand what you're talking about. We are talking about colorizing the output of some compiler:pp command, not to colorize a PP grammar.
@jubianchi Let me ask some colleague designers. Having a pre-defined palette sounds good for me. Else we would have to start a Hoa\Color library and we don't have time for this right now. Your proposed palette seems excellent. What is the source?
@Hywan I randomly generateed 256 colors and manually removed those not fitting in both backgrounds
@ghn points me this https://github.com/mbostock/d3/wiki/Ordinal-Scales#categorical-colors. These palettes have not been designed to work on both light and black backgrounds, but we can maybe find some inspiration there.
Example output with the 80 colors palette:
For each new token we shift a color from the palette and use it.
How do you choose colors in your palette? Are colors already ordered by distance (in which space?)? Do you choose colors by the maximum distance each time?
How do you choose colors in your palette?
For each new token we shift a color from the palette and use it.
Are colors already ordered by distance (in which space?)?
No.
Do you choose colors by the maximum distance each time?
No.
But this is an excellent start! I am going to ask for a “““palette flatter”””
@ghn provides me this other resource: http://kentor.me/posts/generating-pastel-colors-for-css/. @jubianchi, it can help you a lot I guess.
And so this: https://randomcolor.llllll.li/ (a PHP port exists, for inspiration).
@Hywan I searched yesterday for libraries doing good colors randomization and I found https://randomcolor.llllll.li/ was really promising but to do things well, we should port it.
@jubianchi do you want to post your code in a github repository somewhere? Maybe some people can take it as a starting point and continue your work if you don't longer want it.
