Shop-Core icon indicating copy to clipboard operation
Shop-Core copied to clipboard

Forward call sequence error

Open IL0co opened this issue 5 years ago • 0 comments

I noticed an error in the order of calling the "Shop_OnMenuTitle" forward, it is called after all the CallBacks of the category, which is strange to my mind, because it should be called first.

Correction option:

  • make it call before calling callbacks

How did I find it?

  • I needed to get data about where the menu opens (in purchase or in inventory) in the Shop_CategoryDisplayCallback callback, but since it did not have data about ShopAction (I wrote about this in another issue), I decided used the forward "Shop_OnMenuTitle", and then I noticed that it is called after Shop_CategoryDisplayCallback was called

Shop version: 3.05D

IL0co avatar Aug 14 '20 09:08 IL0co