jQuery.countdown icon indicating copy to clipboard operation
jQuery.countdown copied to clipboard

Added TypeScript Definition

Open larrybahr opened this issue 8 years ago • 8 comments

When Googling for TypeScript definition I found that other people were looking for them as well (#274), so I made one. Any feed back would be great.

larrybahr avatar Feb 05 '18 23:02 larrybahr

I have no idea why the Travis CI build failed. I did not make any code changes, just added the definition file. The error is for PhantomJS when doing something with the fakeServer. @hilios, you may want to make sure that your npm test is still working

larrybahr avatar Feb 06 '18 15:02 larrybahr

Thank you @larrybahr I will take a look!

hilios avatar Mar 22 '18 09:03 hilios

@hilios do you plan to accept the pull request? Is there anything I can do to help with your decision?

larrybahr avatar Jul 20 '18 21:07 larrybahr

Man thanks for your contribution. The only thing that bothers me are the failing tests, and would be great if you could add some tests for the typescript module as well. If everything is green I will push the merge button right away.

hilios avatar Jul 20 '18 21:07 hilios

I understand your hesitation, but it looks like the last few pull requests have the same error. I also downloaded a clean copy of your repo and ran the "grunt test" which failed. Can you confirm that the test still works? Do I need a specific version of Node for this to work? Travis-ci is using v0.10.48. Is that required?

larrybahr avatar Jul 20 '18 22:07 larrybahr

@hilios Did you confirm the test still works? The new code should not even hit a test case because it just describes the code (it is a type definition file).

larrybahr avatar Aug 20 '18 20:08 larrybahr

@hilios I do not think the tests work. Can you confirm they are working for you.

larrybahr avatar May 24 '19 20:05 larrybahr

@hilios I can see the last commit to this repo is Dec 31, 2016. The Travis CI builds look like they always fail even for the unmodified code in the master branch. Should I assume this project is dead and my pull request will never be merged?

larrybahr avatar Feb 03 '20 16:02 larrybahr