jQuery.countdown icon indicating copy to clipboard operation
jQuery.countdown copied to clipboard

Zero of time quantity should be plural

Open randallbruder opened this issue 9 years ago • 8 comments

Let's say there's 172 hours in a countdown (1 week and 4 hours.) jQuery.countdown will display this as:

1 week 0 day 4 hours

but according to proper pluralization, this should be:

1 week 0 days 4 hours

randallbruder avatar Dec 13 '16 00:12 randallbruder

Actually, I found the solution, on line 114,

if (Math.abs(count) > 1) {

should be:

if (Math.abs(count) !== 1) {

randallbruder avatar Dec 13 '16 20:12 randallbruder

Made a pull request, let me know if I did this right

randallbruder avatar Dec 13 '16 20:12 randallbruder

Just noticed the same issue, and your fix works for me :)

runofthemill avatar Dec 22 '16 16:12 runofthemill

Bump. This is still an issue, and such a simple fix.

randallbruder avatar Mar 15 '18 22:03 randallbruder

Indeed - please fix!

Eyewash01 avatar Jan 03 '19 17:01 Eyewash01

Bump. This is still an issue

pls fix

trentharms avatar Sep 03 '19 19:09 trentharms

Still an issue. Please fix.

ClarusDignus avatar Sep 21 '21 19:09 ClarusDignus

Actually, I found the solution, on line 114,

if (Math.abs(count) > 1) {

should be:

if (Math.abs(count) !== 1) {

This works. Thanks.

ClarusDignus avatar Sep 21 '21 19:09 ClarusDignus